Refactor for new docker api plugin #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Maybe it's because of a new mockito, or because I used a new JVM, but this test code failed, complaining that it couldn't mock a private interface.
- This version contains its own DelegatingDockerClient implementation, which will mean we don't have to have our own version.
|
@ericcitaire I've tried this locally and it passes unit-tests on my local machine ... but I don't have any spare time right now to do anything more in depth than that. ... and then that should make it safe for you to make "brave" changes to the docker-java-api-plugin without fear of breaking this one 😁 |
6 tasks
|
@pjdarton I made some basic tests on a Jenkins with both docker-java-api-plugin v3.1.5-31.v70b0ca3e8310 and this one installed. Everything looks OK. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take advantage of DelegatingDockerClient that's now present in https://github.com/jenkinsci/docker-java-api-plugin/releases/tag/3.1.5-31.v70b0ca3e8310
This should (hopefully) loosen the tight dependency between the docker-java-api-plugin and this plugin, allowing the docker-java-api-plugin to change the version of docker-java in use without breaking this plugin entirely.